Add Arm and Event API #278
Conversation
|
Amazing thank you! I'll take a look at some point this weekend or early next week |
Codecov Report
@@ Coverage Diff @@
## master #278 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 21 +2
Lines 571 625 +54
=========================================
+ Hits 571 625 +54
|
These broke because REDCap has added the 'alerts' parameter in the most recent version. Nothing you did, just an API change
There was a problem hiding this comment.
This is truly incredible. Without a doubt, the cleanest PR I've ever received, and especially impressive for a first time contributor. Not only do the code changes mesh perfectly with the rest of the codebase but you also updated docs (and doctests), unit tests, and integration tests which are each a world of their own.
I'm super impressed 🤩 If you're ever looking for a job, let me know, you seem like a grade-A coder.
I've made a few updates to the integration/doctests (which was to be expected since you don't have permissions run them) that you can review here: patking02#1
Once these are merged, I'll merge this PR and cut a new release pronto ⚡
Arms & Events PR fixes
|
Thanks for the kind words; the PyCap library is well maintained and has a lot of good checks and standards in place that made my job easy. Happy to help contribute and give back to the community. Thank you for reviewing the PR. |
Fixes #276 and #277
Adds Arm and Event API methods, tests, and documentation.
I initially was going to separate these two out (one PR for Arm, one for Event), but while writing the tests for Arm, I realized I needed to attach an Event to the Arm in order for the Arm Export to return the newly added arm. If need be, I can do one at a time (I guess Event then Arm), but if it is OK to submit/review both at the same time, then here they are.
I tested the Unit tests, but I did not have access to run the Integration Tests, FYI.