-
Notifications
You must be signed in to change notification settings - Fork 21
replace node server with caddy and hexo with hugo #314
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I strongly approve.
(Aside from the comment)
9d88066
to
9660943
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. I got 2 questions but they are non blocking.
Will the circleci test start passing after this is merged or is it very broken? |
Conflicts with some commits I made a few hours ago, once he has those files, it should be passing ci again and good to merge. |
2beb5ce
to
cfa289d
Compare
while chatting too @m1cr0man offline he mentioned a possible rewrite id like to suggest using hugo and using https://caddyserver.com/docs/http.hugo this will have to manually deployed now by one of the @admins |
We talked about the idea last Thursday with @Frazl A hugo replacement would be very nice. Probably not as extendable as hexo is, but then again, we only use some of the existing extensions. |
I think you'll find that a lot of the extensions that are used in hugo can be taken care of by some nice templates in hugo. Using caddy you can also get a lot of the minification advantages you got in hexo |
a hugo rewite would also mean sistem, redbrick and admin-blog would all be the same platform |
98277c7
to
90b3fef
Compare
Hm, that last one is a pretty compelling argument. I will look into what we can do with Hugo then, and how the other 2 sites are currently set up/what differs between them (if anything). My main concern with these templating engines is that once you want to deviate from the template it gets more complex than it is worth. |
63dfa99
to
72fc1ff
Compare
this convo may want to be moved to an issue. admin-blog is just plain css and no js ping me with any questions |
Yeah, all three being one and the same would be nice. Best move it to issue for now like you say |
98d5fc6
to
4bf8946
Compare
tests are now passing, when an admin is available to deploy the new container and very its all working you can merge it should be noted the reason tests were not working was one of the dependency upgrades I tried mangled the use of |
1c223b9
to
af5d6e6
Compare
fc731e1
to
e4cafb3
Compare
@m1cr0man @theycallmemac updated with hugo
|
I will review this too James so please don't merge if you beat me to it |
04e0663
to
b61c74e
Compare
@m1cr0man Did you get to take a look or will I? @theycallmemac If you got to have a look feel free to leave a review |
Ah, yes I will review at lunch time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@butlerx will review this evening when I finished off some college work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to merge this now @butlerx but a question with CircleCI, why is it saying checks have yet to complete, I guess it's using the old config yeah?
circle is broken, think the keys expired |
Move Theme in to the repository - remove submodules - keep all resources in one repo - simplify build - simplify setup Migrate stylus to scss - stylus is mostly dead and not well understood - scss is closer to standard css Migrate Hexo with Hugo - removes need for node - hugo used in other redbrick sites - hugo has built in scss building - cirlceci has predefined build env and tests for hugo Replace custom node server with caddy - replaces custom build process with standard caddy git plugin - add support for github and gitea webhooks Adds basic json interface.
b61c74e
to
f08a4df
Compare
f47685c
to
c128d07
Compare
Closes #
Description
Remove node app.
None of these features are used and add complexity so should be removed
Checklist
I confirm that before I submitted this pull request I did the following:
yarn start
and confirmed that there were no issues.