Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruff to pre-commit #40

Merged
merged 3 commits into from
Feb 2, 2024
Merged

Add Ruff to pre-commit #40

merged 3 commits into from
Feb 2, 2024

Conversation

ScuffedNewt
Copy link
Contributor

@ScuffedNewt ScuffedNewt commented Feb 2, 2024

Adds Ruff (mentioned in issue #31).
This does not add nox as mentioned in issue 31 as nox is for "for automated testing" as mentioned on the issue so out of this PR's scope
uses pre-commit

@JedHazaymeh JedHazaymeh requested a review from novanai February 2, 2024 21:44
@ScuffedNewt
Copy link
Contributor Author

I would like to mention that black and ruff have of course been run on this commit(s)

@JedHazaymeh
Copy link
Contributor

I would like to mention that black and ruff have of course been run on this commit(s)

I noticed 😆 I am judging the styling. Are the current rules the default (and/or the recommended standard)?

@ScuffedNewt
Copy link
Contributor Author

I noticed 😆 I am judging the styling. Are the current rules the default (and/or the recommended standard)?

yes current linting is by PEP 8 standards and default, no configs added etc

@ScuffedNewt
Copy link
Contributor Author

removed black after some brief discussion on discord 🤠

@ScuffedNewt ScuffedNewt linked an issue Feb 2, 2024 that may be closed by this pull request
Copy link
Contributor

@JedHazaymeh JedHazaymeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@JedHazaymeh JedHazaymeh changed the title Add Black and Ruff to pre-commit Add Ruff to pre-commit Feb 2, 2024
@JedHazaymeh JedHazaymeh merged commit e4144a5 into redbrick:main Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ruff pre-commit for code formatting
2 participants