Add same background to App as Spash on android #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RGBboy
changed the title
|
Checked this and is an improvement on the white 👍 |
|
Hm, I think the better option would be to set the SplashTheme as the application/android:theme here: Because we use the clean AppTheme once the SplashScreen activity has been loaded: I think this is important in case we have any transparent views in React Native. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #591. This should fix the white screen flash Android users see when updating the app. This does not seem to happen when opening an already installed app (that has been opened before) Note: There is still a fade of solid color. I'm not sure how to get rid of this.
In order to test you will need to uninstall the app an reinstall it.
Tester check-list
Tested on a number of Android devices:
Optional: