status bar now has correct height to include back link on iphone X #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RGBboy
approved these changes
Jul 9, 2018
|
I spoke to Jun and Steve on Friday and they said to go with it. |
RGBboy
suggested changes
Jul 9, 2018
| @@ -39,7 +39,7 @@ | |||
| "react-native-map-link": "^1.0.6", | |||
| "react-native-maps": "^0.21.0", | |||
| "react-native-permissions": "^1.1.1", | |||
| "react-native-safe-area-view": "robbiemccorkell/react-native-safe-area-view", | |||
| "react-native-safe-area-view": "^0.9.0", | |||
There was a problem hiding this comment.
There is one more part that needs removing later in this file on the resolutions property.
There was a problem hiding this comment.
resolutions removed, pushed up 👍
RGBboy
approved these changes
Jul 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#445
Fixed issue with the overflowing back link in the status bar by updating the version of 'react-native-safe-area-view'.
Tester check-list
Tested on multiple devices / OS versions (Test on the physical device(s) you have access to, otherwise use BrowserStack):
Optional:
Accessibility Testing (If applicable)
Weak connection testing (If applicable)