Add Edit Jam page #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In both the create jam page and the edit jam page we have the same behaviour of allowing the admin to modify "new" statements. This consists of the admin triggering an event which causes the statement to become editable, and from that state triggering some event to go back to the read-only state. I added the ComponentSwitcher component so that we can re-use the code to switch between components without making any assumptions to which event triggers the switching.
Midnite
reviewed
Aug 31, 2021
Midnite
reviewed
Aug 31, 2021
ruiramos
reviewed
Aug 31, 2021
ruiramos
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought I'd submit this as a PR so people can test the preview deployment. I've linked it up to the moderator home page too so you should be able to click through all the way.
Functionality wise I think everything is here now (apart from adding new statements, but I need to re-use some components for that), let me know if I've missed something.
The few things that I know are missing are styling based:
Closes #27