Feature loading images #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlakeTurner
reviewed
Mar 28, 2017
android/settings.gradle
Outdated
| ======= | ||
| include ':react-native-image-to-base64' | ||
| project(':react-native-image-to-base64').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-image-to-base64/android') | ||
| >>>>>>> Linked Camera roll through xCode. |
BlakeTurner
suggested changes
Mar 28, 2017
js/scenes/CameraRoll/index.js
Outdated
| class CameraRollView extends Component { | ||
| constructor(props) { | ||
| super(props); | ||
| const controls = props.controls; |
There was a problem hiding this comment.
Why is this line here?
js/scenes/CameraRoll/index.js
Outdated
| CameraRoll.getPhotos({ first: 100 }).done( | ||
| (data) => { | ||
| const assets = data.edges; | ||
| const images = assets.map(asset => asset.node.image); |
There was a problem hiding this comment.
suggest data.edges.map. You don't need the assets var.
js/scenes/CameraRoll/index.js
Outdated
| }); | ||
| const mapStateToProps = state => ({ | ||
|
|
||
| }); |
There was a problem hiding this comment.
This is empty, delete it.
| new MapsPackage() | ||
| ======= | ||
| new ImageToBase64Package() | ||
| >>>>>>> Linked Camera roll through xCode. |
BlakeTurner
approved these changes
Mar 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #172