[Test] Validate the status of hosts in cluster post upgrade #4257
Conversation
sayaleeraut
requested review from
vinpapnoi,
vamahaja,
MohitBis and
pranavprakash20
sayaleeraut
force-pushed
the
ceph_orch_marks_host_offline
branch
from
fb7dc55
to
b772077
Compare
cli/ops/host.py
Outdated
| @@ -17,11 +17,16 @@ def check_host_status(node, hostname, status=None): | |||
| status: custom status check for the host | |||
| """ | |||
| conf = {"host_pattern": hostname, "format": "json-pretty"} | |||
| out = loads(CephAdm(node).ceph.orch.host.ls(**conf)) | |||
| out = loads((CephAdm(node).ceph.orch.host.ls(**conf))[node[0].hostname][0]) | |||
There was a problem hiding this comment.
Hi @sayaleeraut
Can you please not change lib for specific hosts since same lib used in other suites as well (Impact other suites as well)
If required to use method with changes , Please create in test file
There was a problem hiding this comment.
Yes, done, please review @MohitBis
| from utility.log import Log | ||
|
|
||
| log = Log(__name__) | ||
|
|
There was a problem hiding this comment.
HI @sayaleeraut
You can create method here for "check_host_status" as per your requirment
Thanks,
Mohit Bisht
There was a problem hiding this comment.
Done, added a local method to the test file itself.
Signed-off-by: “sayalee” <[email protected]>
sayaleeraut
force-pushed
the
ceph_orch_marks_host_offline
branch
from
b772077
to
11ee319
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: MohitBis, sayaleeraut, vinpapnoi The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Please include Automation development guidelines. Source of Test case - New Feature/Regression Test/Close loop of customer BZs
click to expand checklist