-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blustore Checked #4255
base: master
Are you sure you want to change the base?
blustore Checked #4255
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Divya-78 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: pdivyagowri <[email protected]>
4265d98
to
844d837
Compare
@@ -133,6 +135,60 @@ def run(ceph_cluster, **kw): | |||
log.info( | |||
f"OSDs successfully deployed with the new alloc size, and verified the size on OSD: {osd_id}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pre_deployment_config_changes and post_deployment_config_verification are the same. Can you create a single method to verify the pre- and post-deployment of OSDs? Please discuss this with the team.
) | ||
|
||
# determine osd's block device path | ||
_cmd = f"cephadm shell -- ceph daemon osd.{osd_id} config show --format json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
create a new method for this in ceph_core
daemon_alloc_size_ssd = json_out["bluestore_min_alloc_size_ssd"] | ||
|
||
if ( | ||
not daemon_alloc_size_hdd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the check here
daemon_alloc_size_ssd = json_out["bluestore_min_alloc_size_ssd"] | ||
|
||
if ( | ||
not daemon_alloc_size_hdd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update the check here
Automation of the issue: BZ - 2183485
The steps are updated at - CEPH-83594019
Automation steps:-