Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blustore Checked #4255

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Divya-78
Copy link

Automation of the issue: BZ - 2183485
The steps are updated at - CEPH-83594019
Automation steps:-

  1. Deploy Ceph Cluster
  2. Verify Bluestore Min Alloc Size Configuration.
  3. Check default value of bluestore_min_alloc_size on cluster.
  4. Change Bluestore Min Alloc Size to Custom Value
  5. Modify bluestore_min_alloc_size_hdd and bluestore_min_alloc_size_ssd.
  6. Verify updated values on the cluster.
  7. Verify Bluestore Min Alloc Size Post-OSD Deployment
  8. Check if values are correctly set on OSDs after deployment.
  9. Validate Configs Post-OSD Deployment
  10. Use ceph config get, Ceph osd Metadata, ceph config show and ceph daemon config show for each OSD to check bluestore_min_alloc_size.
  11. Remove OSD from Cluster
  12. Drain and remove OSD, wait for recovery.
  13. Verify Bluestore Min Alloc Size After OSD Removal
  14. Check if bluestore_min_alloc_size is preserved after OSD removal and redeployment.
  15. Add OSD Back to Cluster
  16. Redeploy OSD and validate bluestore_min_alloc_size.
  17. Check Config and Daemon After OSD Addition
  18. Ensure bluestore_min_alloc_size is correctly set on newly added OSD.
  19. Restore Default Bluestore Min Alloc Size
  20. Set bluestore_min_alloc_size back to default values.
  21. Perform Final Validation of Bluestore Min Alloc Size.

Copy link
Contributor

openshift-ci bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Divya-78

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Divya-78 Divya-78 self-assigned this Nov 25, 2024
@pdhiran pdhiran added the RADOS Rados Core label Nov 26, 2024
Signed-off-by: pdivyagowri <[email protected]>
@@ -133,6 +135,60 @@ def run(ceph_cluster, **kw):
log.info(
f"OSDs successfully deployed with the new alloc size, and verified the size on OSD: {osd_id}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pre_deployment_config_changes and post_deployment_config_verification are the same. Can you create a single method to verify the pre- and post-deployment of OSDs? Please discuss this with the team.

)

# determine osd's block device path
_cmd = f"cephadm shell -- ceph daemon osd.{osd_id} config show --format json"
Copy link
Contributor

@pdhiran pdhiran Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create a new method for this in ceph_core

daemon_alloc_size_ssd = json_out["bluestore_min_alloc_size_ssd"]

if (
not daemon_alloc_size_hdd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the check here

daemon_alloc_size_ssd = json_out["bluestore_min_alloc_size_ssd"]

if (
not daemon_alloc_size_hdd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the check here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RADOS Rados Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants