fix: use cleanup.sh script to uninstall in sm clusters #2071
+5
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CFSNM
requested review from
MarianMacik,
mattmahoneyrh,
aloganat,
jstourac,
bdattoma and
asanzgom
CFSNM
force-pushed
the
test_uninstall_sm
branch
from
07825c7
to
0b36425
Compare
Robot Results
|
aloganat
previously approved these changes
Nov 25, 2024
|
I'm adding @lugi0 and @tarukumar among the reviewers because from the history of the file it seems they were the main maintainer of that uninstall keyword. |
|
thanks @bdattoma |
CFSNM
force-pushed
the
test_uninstall_sm
branch
from
0b36425
to
a3ef31d
Compare
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -55,7 +52,7 @@ | |||
| Uninstall RHODS In Self Managed Cluster Using CLI | |||
| [Documentation] UnInstall rhods on self-managedcluster using cli | |||
| Clone OLM Install Repo | |||
| ${return_code} Run and Watch Command cd ${EXECDIR}/${OLM_DIR} && ./cleanup.sh -t operator timeout=10 min | |||
| ${return_code} Run and Watch Command cd ${EXECDIR}/${OLM_DIR} && ./cleanup.sh -t operator -k timeout=10 min | |||
Check warning
Code scanning / Robocop
Keyword name '{{ keyword_name }}' does not follow case convention Warning
asanzgom
approved these changes
Nov 25, 2024
bdattoma
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @bdattoma and @aloganat, we were not using olminstall scripts to uninstall ODH/RHOAI. This PR replaces the "Uninstall RHODS V2" Kw by the one for selfmanaged clusters, using cleanup script