Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip][ui] Fix model mesh tests and add kserve test #2060

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

[wip][ui] Fix model mesh tests and add kserve test #2060

wants to merge 7 commits into from

Conversation

rnetser
Copy link
Contributor

@rnetser rnetser commented Nov 21, 2024

No description provided.

@rnetser
Update model mesh deploymenet from ui
6d7c959 
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@rnetser
add raw and serverless
7e43475 
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@rnetser
add raw and serverless
9c24c8a 
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 21, 2024
View reviewed changes
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHModelServing.resource
Page Should Contain Element xpath://span[contains(., "${runtime}")]
${selected}= Run Keyword And Return Status
... Click Element xpath://span[contains(., "${runtime}")]
IF ${selected}==${TRUE} BREAK

Check notice

Code scanning / Robocop

'{{ block_name }}' condition can be simplified Note test

'INLINE IF' condition can be simplified
ods_ci/tests/Tests/1000__model_serving/1007__model_serving_llm/1007__model_serving_llm.robot
Comment on lines +113 to +114
...
Verify User Can Deploy Raw and Serverless Models In The Same Namespace # robocop: off=too-long-test-case,too-many-calls-in-test-case,line-too-long

Check warning

Code scanning / Robocop

Invalid number of empty lines between test cases ({{ empty_lines }}/{{ allowed_empty_lines }}) Warning test

Invalid number of empty lines between test cases (0/1)
ods_ci/tests/Tests/1000__model_serving/1007__model_serving_llm/1007__model_serving_llm.robot
@@ -110,6 +110,47 @@
... n_times=10 namespace=${test_namespace}
[Teardown] Clean Up Test Project test_ns=${test_namespace}
... isvc_names=${models_names} wait_prj_deletion=${FALSE}
...

Check warning

Code scanning / Robocop

Trailing whitespace at the end of line Warning test

Trailing whitespace at the end of line
ods_ci/tests/Tests/1000__model_serving/1007__model_serving_llm/1007__model_serving_llm.robot
${test_namespace}= Set Variable ${TEST_NS}-multisame
${model_one_name}= Set Variable bloom-560m-caikit
${model_two_name}= Set Variable flan-t5-small-caikit
${models_names}= Create List ${model_one_name} ${model_two_name}

Check notice

Code scanning / Robocop

{{ create_keyword }} can be replaced with VAR Note test

Create List can be replaced with VAR
...erving/1010__model_serving_triton_on_modelmesh/1010__model_serving_triton_on_modelmesh.robot
@@ -54,7 +54,7 @@
Recreate S3 Data Connection project_title=${PRJ_TITLE} dc_name=model-serving-connection
... aws_access_key=${S3.AWS_ACCESS_KEY_ID} aws_secret_access=${S3.AWS_SECRET_ACCESS_KEY}
... aws_bucket_name=ods-ci-s3
Create Model Server token=${TRUE} runtime=${ONNX_RUNTIME_NAME} server_name=${ONNX_RUNTIME_NAME} existing_server=${TRUE}
Create Model Server token=${TRUE} runtime=${ONNX_RUNTIME_NAME} server_name=${ONNX_RUNTIME_NAME} existing_server=${FALSE}

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (136/120)
...erving/1010__model_serving_triton_on_modelmesh/1010__model_serving_triton_on_modelmesh.robot
@@ -130,7 +130,7 @@
Recreate S3 Data Connection project_title=${PRJ_TITLE} dc_name=model-serving-connection
... aws_access_key=${S3.AWS_ACCESS_KEY_ID} aws_secret_access=${S3.AWS_SECRET_ACCESS_KEY}
... aws_bucket_name=ods-ci-s3
Create Model Server token=${TRUE} runtime=${ONNX_RUNTIME_NAME} server_name=${ONNX_RUNTIME_NAME} existing_server=${TRUE}
Create Model Server token=${TRUE} runtime=${ONNX_RUNTIME_NAME} server_name=${ONNX_RUNTIME_NAME} existing_server=${FALSE}

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (136/120)
@rnetser rnetser changed the title [ui] Fix model mesh tests and add kserve test [wip][ui] Fix model mesh tests and add kserve test Nov 21, 2024
@rnetser
Merge branch 'master' of https://github.com/red-hat-data-services/ods-ci
49252a9 
 into fix-model-mesh

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@rnetser
fix tests
99b0b85 
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@rnetser
fix tests
17158de 
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 24, 2024
View reviewed changes
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHModelServing.resource
@@ -226,7 +226,7 @@
[Arguments] ${model_name}
# TODO: Open model serving home page if needed?
# Click on Inference Endpoints link
${endpoint_link}= Set Variable //a[@data-testid="metrics-link-test-model" and text()="${model_name}"]/ancestor::tr//td//button[@data-testid="internal-external-service-button"]
${endpoint_link}= Set Variable //a[contains(@data-testid, 'metrics-link')][text() = '${model_name}']/ancestor::tr//td//button[@data-testid="internal-external-service-button"]

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (184/120)
ods_ci/tests/Tests/1000__model_serving/1001__model_serving_modelmesh.robot
... existing_data_connection=${TRUE} data_connection_name=model-serving-connection
... model_path=inception_resnet_v2.pb
${runtime_pod_name}= Replace String Using Regexp string=${RUNTIME_NAME} pattern=\\s replace_with=-
${runtime_pod_name}= Convert To Lower Case ${runtime_pod_name}
Wait Until Keyword Succeeds 5 min 10 sec Verify Openvino Deployment runtime_name=${RUNTIME_POD_NAME}
Wait Until Keyword Succeeds 5 min 10 sec Verify Serving Service
Wait Until Keyword Succeeds 5 min 10 sec Verify Openvino Deployment runtime_name=${RUNTIME_POD_NAME} project_name=${namespace}

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (141/120)
ods_ci/tests/Tests/1000__model_serving/1001__model_serving_modelmesh.robot
... existing_data_connection=${TRUE} data_connection_name=model-serving-connection
... model_path=inception_resnet_v2.pb
${runtime_pod_name}= Replace String Using Regexp string=${RUNTIME_NAME} pattern=\\s replace_with=-
${runtime_pod_name}= Convert To Lower Case ${runtime_pod_name}
Wait Until Keyword Succeeds 5 min 10 sec Verify Openvino Deployment runtime_name=${RUNTIME_POD_NAME}
Wait Until Keyword Succeeds 5 min 10 sec Verify Serving Service
Wait Until Keyword Succeeds 5 min 10 sec Verify Openvino Deployment runtime_name=${RUNTIME_POD_NAME} project_name=${namespace}

Check warning

Code scanning / Robocop

Variable '{{ name }}' has inconsistent naming. First used as '{{ first_use }}' Warning test

Variable '${RUNTIME_POD_NAME}' has inconsistent naming. First used as '${runtime_pod_name}'
ods_ci/tests/Tests/1000__model_serving/1001__model_serving_modelmesh.robot
Verify Model Status ${MODEL_NAME} success
Set Suite Variable ${MODEL_CREATED} ${TRUE}
${url}= Get Model Route Via UI ${MODEL_NAME}
${status_code} ${response_text}= Send Random Inference Request endpoint=${url} name=input
${status_code} ${response_text}= Send Random Inference Request endpoint=${url} name=input:0

Check notice

Code scanning / Robocop

Variable '{{ name }}' is assigned but not used Note test

Variable '${response_text}' is assigned but not used
ods_ci/tests/Tests/1000__model_serving/1001__model_serving_modelmesh.robot
... existing_data_connection=${TRUE} data_connection_name=model-serving-connection
... model_path=inception_resnet_v2.pb
${runtime_pod_name}= Replace String Using Regexp string=${RUNTIME_NAME} pattern=\\s replace_with=-
${runtime_pod_name}= Convert To Lower Case ${runtime_pod_name}
Wait Until Keyword Succeeds 5 min 10 sec Verify Openvino Deployment runtime_name=${RUNTIME_POD_NAME}
Wait Until Keyword Succeeds 5 min 10 sec Verify Serving Service
Wait Until Keyword Succeeds 5 min 10 sec Verify Openvino Deployment runtime_name=${RUNTIME_POD_NAME} project_name=${namespace}

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (141/120)
ods_ci/tests/Tests/1000__model_serving/1001__model_serving_modelmesh.robot
... existing_data_connection=${TRUE} data_connection_name=model-serving-connection
... model_path=inception_resnet_v2.pb
${runtime_pod_name}= Replace String Using Regexp string=${RUNTIME_NAME} pattern=\\s replace_with=-
${runtime_pod_name}= Convert To Lower Case ${runtime_pod_name}
Wait Until Keyword Succeeds 5 min 10 sec Verify Openvino Deployment runtime_name=${RUNTIME_POD_NAME}
Wait Until Keyword Succeeds 5 min 10 sec Verify Serving Service
Wait Until Keyword Succeeds 5 min 10 sec Verify Openvino Deployment runtime_name=${RUNTIME_POD_NAME} project_name=${namespace}

Check warning

Code scanning / Robocop

Variable '{{ name }}' has inconsistent naming. First used as '{{ first_use }}' Warning test

Variable '${RUNTIME_POD_NAME}' has inconsistent naming. First used as '${runtime_pod_name}'
@rnetser
fix tests
42b2044 
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rnetser