-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add manual event loop option #47
Conversation
Making this a draft because it doesn't have documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial comments
Taking this out of draft mode now that there are docs. It still needs a warning about rate limiting the client but I'm not comfortable writing that section since I haven't tested that behavior myself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Adds a
manual_event_loop
option which exports asend_events
function whentrue
. This is useful when the user can schedulesend_events
after all their other code that runs in the frame.