Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fire in player added #45

Merged
merged 4 commits into from
Jan 2, 2024
Merged

Conversation

nezuo
Copy link
Contributor

@nezuo nezuo commented Jan 1, 2024

Firing a remote on the server inside PlayerAdded is not guaranteed to exist because the user's connection can run before zap's. This fixes the issue by initializing the player inside of fire functions instead of PlayerAdded.

zap/src/output/luau/server.luau Outdated Show resolved Hide resolved
@sasial-dev sasial-dev merged commit fd43f04 into red-blox:main Jan 2, 2024
2 checks passed
@nezuo nezuo deleted the fix-fire-in-player-added branch January 2, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants