Named parameters #141
Merged
Named parameters #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasial-dev
requested changes
Nov 30, 2024
|
Added error for duplicate parameters: |
sasial-dev
reviewed
Dec 1, 2024
|
|
||
| ### `rets` | ||
|
|
||
| This field determines the data that is sent back to the client from the server. It can be any [Zap type](./types.md). | ||
|
|
||
| - If the server doesn't return any data, the `rets` field should be excluded. | ||
| - Unlike `args`, `rets` cannot be named. |
There was a problem hiding this comment.
Maybe we need a better error (sorry) then
error[2002]: expected ")", ",", "?", "["
┌─ net.zap:4:16
│
4 │ rets: (test: enum { Success, Fail }, bar: string)
│ ^ unexpected token
sasial-dev
approved these changes
Dec 1, 2024
|
Improved error for named rets: error[3016]: rets cannot be named
┌─ net.zap:88:12
│
88 │ rets: (foo: f64, boolean),
│ ^^^ must be removed |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: