Add Generalised Tooling Support #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasial-dev
commented
Aug 10, 2024
| self.push_line("local len = buffer.len(incoming_buff)"); | ||
| self.push("\n"); | ||
|
|
||
| self.push_tydecls(); |
There was a problem hiding this comment.
One of the major intents was not to touch the rest of the codebase (e.g irgen), and that meant that the types functions have to be inside the function. Let me know if you think this is an issue.
There was a problem hiding this comment.
This doesn't seem to be as slow as I was expecting it to be...
There was a problem hiding this comment.
@jackdotink - before I merge can you confirm if this is ok?
jackdotink
approved these changes
Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by Pyseph/PacketProfiler#8cc @Pyseph
For tools such as PacketProfiler, there is a need for ability to deserialise a zap buffer while 'in transit' for debugging.
This PR aims to create a standardised way to do this, accepting a function with all the remote's parameters and returning a table with the name and arguments such as: