Change placeholder value to string singleton

red-blox · Oct 8, 2024 · 58e8de2 · 58e8de2
1 parent 9c6e2c0
commit 58e8de2
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 8 deletions.
diff --git a/zap/src/output/luau/client.rs b/zap/src/output/luau/client.rs
@@ -203,9 +203,9 @@ impl<'src> ClientOutput<'src> {
 
 		match ev.call {
 			EvCall::Polling => {
-				// Event types without data use `true` as a placeholder.
+				let name = ev.name;
 				self.push_line(&format!(
-					"table.insert(polling_payload_queues[{id}], if value == nil then true else value)"
+					"table.insert(polling_payload_queues[{id}], if value == nil then \"Zap placeholder value for dataless event \\\"{name}\\\"\" else value)"
 				));
 			}
 			_ => {
@@ -715,7 +715,10 @@ impl<'src> ClientOutput<'src> {
 			self.push_ty(&data);
 			self.push(")");
 		} else {
-			self.push("(() -> true)")
+			let name = ev.name;
+			self.push(&format!(
+				"(() -> \"Zap placeholder value for dataless event \"{name}\"."
+			));
 		}
 		self.push(",\n");
 	}

diff --git a/zap/src/output/luau/server.rs b/zap/src/output/luau/server.rs
@@ -215,9 +215,9 @@ impl<'a> ServerOutput<'a> {
 
 		if let EvCall::Polling = ev.call {
 			self.push_line(&format!("table.insert(polling_player_queues[{id}], player)"));
-			// Event types without data use `true` as a placeholder.
+			let name = ev.name;
 			self.push_line(&format!(
-				"table.insert(polling_payload_queues[{id}], if value == nil then true else value)"
+				"table.insert(polling_payload_queues[{id}], if value == nil then \"Zap placeholder value for dataless event \\\"{name}\\\"\" else value)"
 			));
 		} else {
 			if ev.call == EvCall::SingleSync || ev.call == EvCall::SingleAsync {
@@ -860,7 +860,7 @@ impl<'a> ServerOutput<'a> {
 			self.push_ty(&data);
 			self.push("))");
 		} else {
-			self.push("(() -> (Player, true)")
+			self.push("(() -> Player)")
 		}
 		self.push(",\n");
 	}

diff --git a/zap/src/output/typescript/client.rs b/zap/src/output/typescript/client.rs
@@ -113,7 +113,8 @@ impl<'src> ClientOutput<'src> {
 				if let Some(data) = &ev.data {
 					self.push_ty(data);
 				} else {
-					self.push("true");
+					let name = ev.name;
+					self.push(&format!("\"Zap placeholder for event \\\"{name}\\\"\""));
 				}
 				self.push(";\n");
 			} else {

diff --git a/zap/src/output/typescript/server.rs b/zap/src/output/typescript/server.rs
@@ -187,7 +187,8 @@ impl<'a> ServerOutput<'a> {
 				if let Some(data) = &ev.data {
 					self.push_ty(data);
 				} else {
-					self.push("true");
+					let name = ev.name;
+					self.push(&format!("\"Zap placeholder for event \\\"{name}\\\"\""));
 				}
 				self.push("];\n");
 			} else {