Add RevRec POBs support #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faiberrec
force-pushed
the
add_performance_obligations
branch
from
014320a to
abd05b6
Compare
Smolations
reviewed
Feb 6, 2024
| $this->assertInstanceOf('Recurly_PerformanceObligation', $pob); | ||
| $this->assertEquals('Over Time (Daily)', $pob->name); | ||
| $this->assertEquals('6', $pob->id); | ||
| $this->assertInstanceOf('DateTime', $pob->created_at); |
There was a problem hiding this comment.
Any particular reason you omitted testing for updated_at? 🤔
faiberrec
force-pushed
the
add_performance_obligations
branch
from
9a398b1 to
68a34af
Compare
Smolations
approved these changes
Feb 6, 2024
Smolations
requested changes
Feb 6, 2024
Smolations
approved these changes
Feb 6, 2024
Smolations
force-pushed
the
add_performance_obligations
branch
from
ba8449c to
68a34af
Compare
|
DevQA+1 |
recurly-integrations
pushed a commit
that referenced
this pull request
Mar 13, 2024
[Full Changelog](2.14.7...2.14.8) **Merged Pull Requests** - Add RevRec to adjustments/purchases [#802](#802) ([faiberrec](https://github.com/faiberrec)) - Add revrec attributes to add ons [#801](#801) ([faiberrec](https://github.com/faiberrec)) - Add revrec attributes to items and giftcards [#798](#798) ([faiberrec](https://github.com/faiberrec)) - Add RevRec attributes to shipping methods [#796](#796) ([faiberrec](https://github.com/faiberrec)) - Add revrec attributes to plans [#795](#795) ([faiberrec](https://github.com/faiberrec)) - Add default glas to Business Entities [#794](#794) ([faiberrec](https://github.com/faiberrec)) - Add revrec support to php [#793](#793) ([faiberrec](https://github.com/faiberrec)) - Add RevRec POBs support [#792](#792) ([faiberrec](https://github.com/faiberrec)) - Add GeneralLdegerAccounts(glas) resources [#791](#791) ([faiberrec](https://github.com/faiberrec)) - add external payment phases [#784](#784) ([amandamfielding](https://github.com/amandamfielding))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change creates the PerformanceObligation entity for the V2 client, part of the new (and upcoming) RevRec API features.