Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor: Update issue templates' rector version #6437

Closed
wants to merge 1 commit into from
Closed

minor: Update issue templates' rector version #6437

wants to merge 1 commit into from

Conversation

staabm
Copy link
Contributor

@staabm staabm commented May 19, 2021 •
edited
Loading

Use a more recent version

@staabm staabm changed the title Update issue template minor: Update issue template May 19, 2021
@staabm staabm changed the title minor: Update issue template minor: Update issue template‘s rector version May 19, 2021
@staabm staabm changed the title minor: Update issue template‘s rector version minor: Update issue templates' rector version May 19, 2021
staabm
staabm commented May 19, 2021
View reviewed changes
.github/ISSUE_TEMPLATE/1_Bug_report.md
@@ -10,7 +10,7 @@ about: Report errors and problems

| Subject | Details |
| :------------- | :---------------------------------------------------------------|
| Rector version | e.g. v0.9.5 (invoke `vendor/bin/rector --version`) |
| Rector version | e.g. v0.11.5 (invoke `vendor/bin/rector --version`) |
| Installed as | composer dependency / prefixed Rector |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line can be dropped, because there is only a single install method as of 0.11, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's from the old times 😆

@TomasVotruba
Copy link
Member

These files should be updated in the development repository though.
We use this as a release read-only

This is the directory that is pushed here into the root: https://github.com/rectorphp/rector-src/tree/main/build/target-repository

@staabm
Copy link
Contributor Author

staabm commented May 19, 2021

Here we go rectorphp/rector-src#77

@staabm staabm closed this May 19, 2021
@staabm staabm deleted the patch-3 branch May 19, 2021 19:28
@samsonasik
Copy link
Member

@TomasVotruba I think we can use auto-closer github action for example:

https://github.com/laminas/laminas-db/blob/7663f838059e27da94df02fe4aa88c2c7fd7aa1c/.github/workflows/auto-close.yml

It needs organization token which seems can be saved at .github repository in org level, eg: https://github.com/laminas/.github

The example result is : laminas/laminas-db#189 (comment)

@TomasVotruba
Copy link
Member

We can give it a shot.
Could you add it?

@samsonasik
Copy link
Member

I've added .github repo https://github.com/rectorphp/.github ,currently add my personal access token to secrets, let's try.

@samsonasik samsonasik mentioned this pull request May 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba TomasVotruba left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@staabm @TomasVotruba @samsonasik