-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Php80] Make configurable INLINE_PUBLIC on ClassPropertyAssignToConstructorPromotionRector #3126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
samsonasik
force-pushed
the
make-configurable-inline-public
branch
from
November 29, 2022 10:50
9b7dad7
to
a18861b
Compare
samsonasik
force-pushed
the
make-configurable-inline-public
branch
from
November 29, 2022 12:33
756991b
to
2fd5d0f
Compare
All checks have passed 🎉 @TomasVotruba it is ready for review. |
Thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the following code:
should be skipped by default, as when the
protected $x
is overriden in child without type yet, it will BC break.see https://3v4l.org/BYkPK
I add
INLINE_PUBLIC
configurable which default to false, can be enabled to true to make it changed (can be use for major framework upgrade).Ref codeigniter4/CodeIgniter4#6924 (comment)