Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if requestAnimationFrame is defined in shouldUpdate #81

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Check if requestAnimationFrame is defined in shouldUpdate #81

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34d33ad
Check if requestAnimationFrame is defined in shouldUpdate
branberry Sep 24, 2023
c3fdcb9
Small refactor to make eslint happy
branberry Sep 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/setRafTimeout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export default function setRafTimeout(callback, timeout = 0) {
callback(now);
currTime = -1;
} else {
requestAnimationFrame(shouldUpdate);
if (typeof requestAnimationFrame !== 'undefined') requestAnimationFrame(shouldUpdate);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doing typeof requestAnimationFrame !== 'undefined' for the conditional because using !requestAnimationFrame as the conditional still caused the undefined error. This ensures that we check without throwing an error.

}
};

Expand Down