Update package.json

[denisx]

Add "sideEffects": false for better codspliting

[denisx]

@ckifer I need you help. We need to go a quick 2 minute adventure.

[ckifer]

Not sure what you mean about a 2 minute adventure.

I'm fine with doing this, but it may not help as much as it seems it might

[denisx]

When can we wait for new publich patch version?

[ckifer]

Are you saying publish in general or publish and then install in recharts? I can publish it as soon as a get a few minutes. I can't install it in recharts 2.x, only once 3.0 is out because it goes across a breaking change (3.0 to 4.0)

[denisx]

can we patch 3 and 4 versions?

[ckifer]

generally I wouldn't go back and patch 3.x no. Being that this is a small change it shouldn't be a huge deal

[denisx]

Ok, will think about 4 mirgation

[ckifer]

are using using react-smooth directly? Or are you wanting this change in recharts? I'm still not clear. If you are using react-smooth directly, installing 4.x shouldn't cause any breaking issues. Its just major version bumps of other packages

[denisx]

"shouldn't cause any breaking issues"
oh, super!

"change in recharts
yes, too

[denisx]

you need any help?

[ckifer]

these were the documented breaking changes https://github.com/recharts/react-smooth/releases/tag/v4.0.0

No migration required if none of those things effect you.

I shouldn't need help, just need a minute to take care of the release

[ckifer]

@denisx released in 4.0.2
https://github.com/recharts/react-smooth/releases/tag/v4.0.2

[ckifer]

and actually scratch that about the 3.0 to 4.0 thing
https://github.com/recharts/recharts/blob/master/package.json#L73

recharts uses 4.0 in the master (2.x) branch so all good

[ckifer]

Let me know how much this actually helps your code splitting

[denisx]

will i need to make a pr to rechart? because *.lock file does not up the version of deps itself (or it does any other package)
OR i need to do it myself at my package.json

[ckifer]

The caret (^) takes care of that. If you update your dependencies it should automatically install the latest patch version of react-smooth

[denisx]

if both packages at one project...

[ckifer]

react-smooth is installed implicitly because it is a dependency of recharts. Just run npm update and check your lock file to make sure it updated

[denisx]

i think this is a bit mistake at package.json / files. no index at lib and es6 folders

[ckifer]

good catch. I started migrating to TS and looks like the build process isn't quite right
I'll patch again to prevent chaos from happening when people go to install later...

[ckifer]

4.03 published

[ckifer]

@denisx let me know as soon as you can try it :/ apologies for the miss there