fix: Use shutil.copytree over distutils #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* As setuptools is not the build backend there should be no reliance on setuptools or distutils for use. This exchanges the deprecated distutils.dir_util.copy_tree for shutil.copytree as recast-atlas is Python 3.8+. * Note that as distutils is also deprecated, if this was not done then setuptools._distutils.dir_util.copy_tree would need to be used.
matthewfeickert
added a commit
that referenced
this pull request
Jun 17, 2024
* Add dirs_exist_ok=True to allow the copying operation to continue if it encounters existing directories. - c.f. https://docs.python.org/3.12/library/shutil.html#shutil.copytree - dirs_exist_ok was added in Python 3.8. * Amends PR #155.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
distutils.dir_util.copy_treeforshutil.copytreeasrecast-atlasis Python 3.8+.