Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(morph_logger): basic implementation #26

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

baransu
Copy link

@baransu baransu commented Oct 29, 2019

Resolves: #25

Basic logger implementation based on https://github.com/expressjs/morgan. Not sure if we want this but seams pretty extensible accepting Custom(list(token)) format allowing us to add more tokens in the future.

I also created Headers.re file in morph moving all data structure related stuff and providing get_header function to easily get single header (used in logger to get request or response headers)

TODO:

  • fix formatting - LSP is failing me :/
  • add basic tests

@baransu
Copy link
Author

baransu commented Oct 29, 2019

Not sure why CI is failing 😞 https://github.com/reason-native-web/morph/runs/280516641#step:6:203

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide morph-logger module
1 participant