-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(python): add support for SQLAlchemy 1.4 (#234) #234
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #234 +/- ##
==========================================
- Coverage 74.50% 74.47% -0.03%
==========================================
Files 7 7
Lines 902 901 -1
==========================================
- Hits 672 671 -1
Misses 230 230
|
New warnings: SAWarning: TypeDecorator EncryptedType() will not produce a cache key because the This can be partially fixed by changing I have not seen lower performance locally in any case. |
Fix SQLAlchemy warning reporting conflicting relationships: ``` SAWarning: relationship 'User.workflow' will copy column user_.id_ to column workflow.owner_id, which conflicts with relationship(s): 'User.workflows' (copies user_.id_ to workflow.owner_id), 'Workflow.user_' (copies user_.id_ to workflow.owner_id). If this is not the intention, consider if these relationships should be linked with back_populates, or if viewonly=True should be applied to one or more if they are read-only. For the less common case that foreign key constraints are partially overlapping, the orm.foreign() annotation can be used to isolate the columns that should be written towards. To silence this warning, add the parameter 'overlaps="user_,workflows"' to the 'User.workflow' relationship. (Background on this error at: https://sqlalche.me/e/14/qzyx) ```
1acf3e0
to
8f1c8e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well (using lower boundary).
Please verify that the relationship backref change does not require any alembic upgrade recipe. (Wondering whether the index key names could have changed or some such?)
Fix SQLAlchemy warning reporting conflicting relationships: ``` SAWarning: relationship 'User.workflow' will copy column user_.id_ to column workflow.owner_id, which conflicts with relationship(s): 'User.workflows' (copies user_.id_ to workflow.owner_id), 'Workflow.user_' (copies user_.id_ to workflow.owner_id). If this is not the intention, consider if these relationships should be linked with back_populates, or if viewonly=True should be applied to one or more if they are read-only. For the less common case that foreign key constraints are partially overlapping, the orm.foreign() annotation can be used to isolate the columns that should be written towards. To silence this warning, add the parameter 'overlaps="user_,workflows"' to the 'User.workflow' relationship. (Background on this error at: https://sqlalche.me/e/14/qzyx) ```
I have double checked this and autogenerating a new alembic recipe results in empty downgrade/upgrade methods. Indexes should not be affected by these changes. |
Closes #228