Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mdx compatible with ocaml 5.2 #448

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Conversation

gpetiot
Copy link
Contributor

@gpetiot gpetiot commented Feb 12, 2024

Fix #447

Copy link
Collaborator

@Julow Julow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works :)

The tests are not passing on < 5.2.

test/bin/mdx-test/expect/ocaml-errors/test-case.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@Julow Julow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@gpetiot gpetiot merged commit 3223f2d into realworldocaml:main Feb 15, 2024
3 checks passed
@gpetiot gpetiot deleted the 5.2 branch February 15, 2024 12:21
@kit-ty-kate
Copy link
Contributor

Could we get a release by any chance?

gpetiot added a commit to gpetiot/opam-repository that referenced this pull request Feb 26, 2024
CHANGES:

#### Added

- Handle the error-blocks syntax (realworldocaml/mdx#439, @jonludlam, @gpetiot)
- Allow execution of included OCaml code blocks (realworldocaml/mdx#446, @panglesd)
- Make MDX compatible with OCaml 5.2 (realworldocaml/mdx#448, @gpetiot)

#### Fixed

- Reduce false-positives while detecting warnings (realworldocaml/mdx#440, @Julow)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OCaml 5.2 support
3 participants