-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade mdx to use last version of odoc-parser #439
Conversation
I don't think we should delete the license file from the vendored parser |
It's weird that it doesn't fail, given there is a line to copy |
The update script is now copying the license file from odoc (longer than the previous one) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking forward to not having syntax errors after mdx reports an error in an mld file! 🤩
Co-authored-by: Jon Ludlam <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and ready to be merged to me!
Upgrade mdx to use last version of odoc-parser
CHANGES: #### Added - Handle the error-blocks syntax (realworldocaml/mdx#439, @jonludlam, @gpetiot) - Allow execution of included OCaml code blocks (realworldocaml/mdx#446, @panglesd) - Make MDX compatible with OCaml 5.2 (realworldocaml/mdx#448, @gpetiot) #### Fixed - Reduce false-positives while detecting warnings (realworldocaml/mdx#440, @Julow)
Follow-up on #430
Re-using code from main...jonludlam:mdx:vendor-odoc-parser-richmdx