Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade mdx to use last version of odoc-parser #439

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

gpetiot
Copy link
Contributor

@gpetiot gpetiot commented Sep 29, 2023

Follow-up on #430

  • update script updated
  • vendored parser updated
  • mdx compiles
  • use the new syntax for block output

Re-using code from main...jonludlam:mdx:vendor-odoc-parser-richmdx

lib/block.ml Outdated Show resolved Hide resolved
lib/block.ml Outdated Show resolved Hide resolved
@jonludlam
Copy link
Contributor

I don't think we should delete the license file from the vendored parser

@Leonidas-from-XIV
Copy link
Collaborator

It's weird that it doesn't fail, given there is a line to copy LICENSE.md and the script is set -e.

@gpetiot
Copy link
Contributor Author

gpetiot commented Oct 10, 2023

The update script is now copying the license file from odoc (longer than the previous one)

Copy link
Collaborator

@panglesd panglesd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to not having syntax errors after mdx reports an error in an mld file! 🤩

lib/block.ml Outdated Show resolved Hide resolved
lib/dune Outdated Show resolved Hide resolved
lib/block.ml Outdated Show resolved Hide resolved
lib/block.ml Outdated Show resolved Hide resolved
Copy link
Collaborator

@panglesd panglesd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and ready to be merged to me!

@gpetiot gpetiot merged commit 3226c6e into realworldocaml:main Oct 30, 2023
3 checks passed
@gpetiot gpetiot deleted the odoc.2.3.0 branch October 30, 2023 00:42
edwintorok pushed a commit to edwintorok/mdx that referenced this pull request Jan 16, 2024
Upgrade mdx to use last version of odoc-parser
gpetiot added a commit to gpetiot/opam-repository that referenced this pull request Feb 26, 2024
CHANGES:

#### Added

- Handle the error-blocks syntax (realworldocaml/mdx#439, @jonludlam, @gpetiot)
- Allow execution of included OCaml code blocks (realworldocaml/mdx#446, @panglesd)
- Make MDX compatible with OCaml 5.2 (realworldocaml/mdx#448, @gpetiot)

#### Fixed

- Reduce false-positives while detecting warnings (realworldocaml/mdx#440, @Julow)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants