Skip to content

Commit

Permalink
Fix-ups listener resource creation (#14)
Browse files Browse the repository at this point in the history
* Extract code to increment and return port counter

* Move health and metrics port numbers from the listener_port_map to their own attributes and adjust their listener creation

* Move manhole too, have to support this

* Create port attributes for replication listeners and for the primary 'main' listener

'main' being the combination of any given 'client', 'federation', or 'media' listener

* Populate new replication_port attrib, and remove it from the rest of the old listener_resources

by removing it, it should not be added when the rest of that Set is itemized

* Update shared config handling, as there will ever only be a single port for replication on a given worker

and it won't be found where it used to be at

* Remove most usages of listener_port_map to the new main_port attrib and swap out the last listener block construction

grab the last replication listener processing here too, since removing it was hard but turned out to be dead now anyway

* endpoint_patterns no longer has a need to be a Dict, so make it a Set

* Since endpoint_patterns is now a Set, and listener_port_map is now defunct, migrate for new usage

This should remove the last of the listener_port_map attribute that is no longer used.
Also should simplify endpoint pattern now that they are no longer tied to listener type.

* Don't use these anymore

* Dead code

* Lint

* Remove what used to add the type of listener to the upstream block name

* The point of the whole thing was...

* Work to follow up on at a later time
  • Loading branch information
realtyem authored Aug 5, 2024
1 parent b11fafc commit 237e12d
Showing 1 changed file with 128 additions and 157 deletions.
Loading

0 comments on commit 237e12d

Please sign in to comment.