Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

[SDK-301] Add handling of expired refresh token #38

Merged
merged 6 commits into from
Aug 8, 2023

Conversation

rYuuk
Copy link
Contributor

@rYuuk rYuuk commented Aug 3, 2023

SDK-301

Description

How to Test

  • It can be tested by adding the mock code for refresh token expiry which can be seen in commit cd723e2

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

@rYuuk rYuuk self-assigned this Aug 3, 2023
Copy link
Collaborator

@HarrisonHough HarrisonHough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and seems to work.

@rYuuk rYuuk merged commit ea78275 into release/v0.5.0 Aug 8, 2023
@rYuuk rYuuk deleted the bugfix/refresh-token-expiry-handling branch August 8, 2023 11:59
@@ -16,7 +16,7 @@ public struct PartnerAsset
public LockedCategories[] LockedCategories;
}

public struct LockedCategories
public class LockedCategories
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this intentional?

{
newTokens = await AuthenticationRequests.RefreshToken(userSession.Token, userSession.RefreshToken);
}
catch (Exception e)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should check for 401 error here as well, instead of checking for all kind of error codes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants