feat: add exports #1044
Merged
feat: add exports #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,5 +1,5 @@ | |||
| ARG NODE_VERSION=18 | |||
| FROM node:${NODE_VERSION}-alpine3.18 | |||
There was a problem hiding this comment.
The docker image were using is deprecated now. I think this is the cause of the font changes in all the snapshots?
Comment on lines
-11
to
-18
| ifeq ($(USE_LEGACY), true) | ||
| dockerfile = -f Dockerfile.legacy | ||
| endif | ||
|
|
||
| ifeq ($(USE_LEGACY), true) | ||
| dockerfile = -f Dockerfile.legacy | ||
| endif | ||
|
|
There was a problem hiding this comment.
The 'legacy' Dockerfile was for supporting node v18. node 18 is very close to end of life and we weren't even running tests against it anymore.
|
This PR was released!🚀 Changes included in v7.12.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Adds support for multiple exports.
Prior to this, we were simply ignoring any non-default exports. This pulls the exports from the passed in components, and adds them to the hook that provides component lookup.
🧬 QA & Testing