Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors need to interrupt application #9

Open
SolomonShorser-OICR opened this issue Sep 17, 2020 · 2 comments
Open

Errors need to interrupt application #9

SolomonShorser-OICR opened this issue Sep 17, 2020 · 2 comments

Comments

@SolomonShorser-OICR
Copy link
Collaborator

During a recent run of DownloadDirectory in Jenkins, two steps failed: models2pathsways, and GOAnnotationFile. Both ended in error but the main DownloadDirectory "step" in Jenkins completed.

  1. Errors should terminate the main program, rather than be suppressed.
  2. Really, each "step" within the DownloadDirectory program should be its own Jenkins step.That way if one fails, the others are not affected.
@cookersjs
Copy link
Contributor

This is still a holdover from running the release by directly calling the DownloadDirectory jar file that allowed all steps to run without terminating if one failed. This will be adjusted so that in Jenkins it is actually terminated -- maybe once it gets to the stage to output which steps had errors, it will throw an error instead of running to completion

@SolomonShorser-OICR
Copy link
Collaborator Author

Jenkins can run steps in parallel. I think the optimal solution would be to have Jenkins run as many different DownloadDirectory "steps" in parallel as possible. If one of them fails, only that would should be re-executed using "restart from stage", or by commenting out the others in the Jenkinsfile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants