Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gujarati as new language for React doc #263

Merged
merged 4 commits into from
May 16, 2023
Merged

Conversation

harshilparmar
Copy link
Contributor

Sorry , I don't have have direct experience to contribute to translation yet but I had started contributing to old react dev doc: stale-reactjs-org-translations/gu.reactjs.org#1
stale-reactjs-org-translations/gu.reactjs.org#6

But other than translation, I also made contribution to redux doc: reduxjs/react-redux#1655
And I always tries to give my contribution to react:
reactjs/react.dev#3012
https://twitter.com/Harshil__parmar/status/1578469780092485633?s=20

I hope these might help to evaluate me.

Sorry , I don't have have direct experience to contribute to translation yet but I have started contributing to old react dev doc:
stale-reactjs-org-translations/gu.reactjs.org#1
stale-reactjs-org-translations/gu.reactjs.org#6

But other than translation, I also made contribution to redux doc: reduxjs/react-redux#1655
And also made some suggestion that might be helpful to write new react doc :https://twitter.com/Harshil__parmar/status/1578469780092485633?s=20
I hope these might help to evaluate me.
@vercel
Copy link

vercel bot commented Apr 25, 2023

@harshilparmar is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a part of fixing the permission sync process, we've changed how we track languages — please see 63a10c4.
Could you please update this PR:

  • Rebase on top of latest main, and add the language to lang/langs.json instead
  • Include the list of maintainers into the PR comment body instead

Thank you, and sorry for the churn.

@harshilparmar
Copy link
Contributor Author

As a part of fixing the permission sync process, we've changed how we track languages — please see 63a10c4. Could you please update this PR:

  • Rebase on top of latest main, and add the language to lang/langs.json instead
  • Include the list of maintainers into the PR comment body instead

Thank you, and sorry for the churn.

Thanks @gaearon , I have updated this PR.

@idarshan181
Copy link

Please add me as a maintainer, I would like to maintain and contribute to translating it to Gujarati actively.

@gaearon gaearon merged commit 2b2bdb6 into reactjs:main May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants