Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(file): handle file diff overwrite properly #757

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

neilime
Copy link
Collaborator

@neilime neilime commented Nov 12, 2024

No description provided.

@neilime neilime linked an issue Nov 12, 2024 that may be closed by this pull request
@neilime neilime self-assigned this Nov 12, 2024
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 89.79592% with 5 lines in your changes missing coverage. Please review.

Project coverage is 65.72%. Comparing base (c67c248) to head (0001974).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/services/file/FileDiffService.ts 81.48% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #757      +/-   ##
==========================================
+ Coverage   65.55%   65.72%   +0.17%     
==========================================
  Files          77       77              
  Lines        2000     2019      +19     
  Branches      348      352       +4     
==========================================
+ Hits         1311     1327      +16     
- Misses        689      692       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neilime neilime merged commit 4381e66 into main Nov 12, 2024
12 checks passed
@neilime neilime deleted the 734-this-behaviour-must-be-implemented branch November 12, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

This behaviour must be implemented
1 participant