Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests for FileFactory #756

Merged
merged 1 commit into from
Nov 9, 2024
Merged

Conversation

neilime
Copy link
Collaborator

@neilime neilime commented Nov 9, 2024

No description provided.

@neilime neilime requested a review from Copilot November 9, 2024 06:35
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 suggestion.

src/services/file/TomlFile.ts Show resolved Hide resolved
Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.59%. Comparing base (73fcd62) to head (93c4bed).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #756      +/-   ##
==========================================
+ Coverage   64.89%   65.59%   +0.70%     
==========================================
  Files          77       77              
  Lines        1997     1997              
  Branches      356      338      -18     
==========================================
+ Hits         1296     1310      +14     
- Misses        632      687      +55     
+ Partials       69        0      -69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Emilien Escalle <[email protected]>
@neilime neilime force-pushed the test/add-tests-for-file-factory branch from 52616d8 to 93c4bed Compare November 9, 2024 06:38
@neilime neilime requested a review from Copilot November 9, 2024 06:38

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (1)

src/services/file/FileFactory.spec.ts:56

  • The error message for a non-existing file should be more specific and match the expected message in the test case.
await expect(fileFactory.fromFile("non-existing-file")).rejects.toThrow('File "non-existing-file" does not exist');
@neilime neilime merged commit 9a34bb9 into main Nov 9, 2024
12 checks passed
@neilime neilime deleted the test/add-tests-for-file-factory branch November 9, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant