Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(commands): add a command for a list of "good to know" items for job applications, particularly juniors #394

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

mwskwong
Copy link
Contributor

@mwskwong mwskwong commented Aug 4, 2024

The list of items is open for discussion. Feel free to comment, add, update, or remove some of the items.

I added dedent for better DX. Please let me know if you prefer not to do this in this PR, or use dedent to all other commands at once.

Copy link

what-the-diff bot commented Aug 4, 2024

PR Summary

  • Inclusion of new package 'dedent'
    The team has included a new package titled 'dedent' in our list of software libraries. We've specifically opted for version 1.5.3, and this has been added to our primary reference files (package-lock.json and package.json), which are basically the 'table of contents' for our project.

  • Utilization of 'dedent' in Command Features
    In the file src/features/commands.ts, which controls a variety of operational and functional commands, the 'dedent' package has been put to use. More specifically, we've added a new item to a certain list that uses some fancy text formatting. Help prompts, classification schemes, and message handling methods have all been defined for this new item.

Copy link
Member

@vcarl vcarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise this seems good to me! Saw you ask for feedback in the channel, this is good to merge if there isn't any dissent there

package.json Outdated Show resolved Hide resolved
@mwskwong
Copy link
Contributor Author

mwskwong commented Aug 5, 2024

@vcarl @ghardin137 @kristersd There seem to be some issues with the build pipeline. Could you have a look?

@vcarl
Copy link
Member

vcarl commented Aug 7, 2024

Sorry @mwskwong hadn't seen this! That's a known issue (#216), I ignored it for a while cuz it was ~ just me contributing hehe. Has been more and more confusing so I killed the thing causing it 👍 tyty

@mwskwong
Copy link
Contributor Author

mwskwong commented Aug 7, 2024

@vcarl I see. I guess your side need to re-trigger the checks or force merge this PR then, since I don't have permission to do so.

@kristersd kristersd merged commit ba3c491 into reactiflux:main Aug 7, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants