-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(commands): add a command for a list of "good to know" items for job applications, particularly juniors #394
Conversation
…job applications, particularly juniors
PR Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise this seems good to me! Saw you ask for feedback in the channel, this is good to merge if there isn't any dissent there
@vcarl @ghardin137 @kristersd There seem to be some issues with the build pipeline. Could you have a look? |
@vcarl I see. I guess your side need to re-trigger the checks or force merge this PR then, since I don't have permission to do so. |
The list of items is open for discussion. Feel free to comment, add, update, or remove some of the items.
I added
dedent
for better DX. Please let me know if you prefer not to do this in this PR, or usededent
to all other commands at once.