New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor useDeviceOrientation hook #212

Closed

LinusU wants to merge 1 commit into main from LinusU-useDeviceOrientation

Member

LinusU commented Nov 4, 2020

Summary

Simplifies the code, and also fixes an issue where the initial value could be stale as described in #210

Test Plan

Will test this in a snack, will update with link shortly

What's required for testing (prerequisites)?

nothing special

What are the steps to reproduce (after prerequisites)?

change the orientation and observe the updated value

Compatibility

OS	Implemented
iOS	✅
Android	✅
Web	✅

Checklist

I have tested this on a device and a simulator
[n/a] I added the documentation in README.md
[n/a] I updated the typed files (TS and Flow)
I've created a snack to demonstrate the changes: LINK HERE


          Refactor useDeviceOrientation hook

8c3d121

Member Author

LinusU commented May 23, 2023

No longer needed because of #322

LinusU closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet