fix: scroll position should be reset when all tabs are removed (#332)

* reset scroll when there is no active tab * add test: scroll to 0 when activeKey is null
react-component · Nov 16, 2020 · cadd00a · cadd00a · vercel · Nov 16, 2020
1 parent f6b8589
commit cadd00a
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/src/TabNavList/index.tsx b/src/TabNavList/index.tsx
@@ -207,9 +207,13 @@ function TabNavList(props: TabNavListProps, ref: React.Ref<HTMLDivElement>) {
 
   // ========================= Scroll ========================
   function scrollToTab(key = activeKey) {
-    const tabOffset = tabOffsets.get(key);
-
-    if (!tabOffset) return;
+    const tabOffset = tabOffsets.get(key) || {
+      width: 0,
+      height: 0,
+      left: 0,
+      right: 0,
+      top: 0,
+    };
 
     if (tabPositionTopOrBottom) {
       // ============ Align with top & bottom ============

diff --git a/tests/overflow.test.tsx b/tests/overflow.test.tsx
@@ -276,6 +276,15 @@ describe('Tabs.Overflow', () => {
       expect(getTransformX(wrapper)).toEqual(-20);
       expect(onTabScroll).toHaveBeenCalledWith({ direction: 'left' });
 
+      // scroll to 0 when activeKey is null
+      onTabScroll.mockReset();
+      wrapper.setProps({ activeKey: null });
+      act(() => {
+        jest.runAllTimers();
+        wrapper.update();
+      });
+      expect(getTransformX(wrapper)).toEqual(0);
+
       jest.useRealTimers();
     });