Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump [email protected] #988

Merged
merged 8 commits into from
Oct 24, 2023
Merged

chore: bump [email protected] #988

merged 8 commits into from
Oct 24, 2023

Conversation

RedJue
Copy link
Contributor

@RedJue RedJue commented Oct 23, 2023

@vercel
Copy link

vercel bot commented Oct 23, 2023

@RedJue is attempting to deploy a commit to the React Component Team on Vercel.

A member of the Team first needs to authorize it.

MadCcc
MadCcc reviewed Oct 23, 2023
View reviewed changes
tsconfig.json Outdated
Comment on lines 22 to 29
"include": [
".dumi/**/*",
".dumirc.ts",
"./src/**/*.ts",
"./src/**/*.tsx",
"./docs/**/*.tsx",
"./tests/**/*.tsx"
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没用到 .dumi，这里可以不用加 include

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

行，那我去掉

crazyair
crazyair reviewed Oct 23, 2023
View reviewed changes
.dumirc.ts Outdated
import path from 'path';

export default defineConfig({
alias: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tsconfig 加应该就够了

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1

@crazyair
Copy link
Contributor

要加 setup

@RedJue
Copy link
Contributor Author

RedJue commented Oct 23, 2023

要加 setup

加在哪?

@crazyair
Copy link
Contributor

要加 setup

加在哪?

https://d.umijs.org/guide/upgrading#%E6%9B%B4%E6%96%B0-packagejson

crazyair
crazyair reviewed Oct 23, 2023
View reviewed changes
tsconfig.json
"@@/*": ["src/.umi/*"],
"rc-select": ["src/index.ts"]
}
"@/*": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个如果是 jsonc 格式，那这个就是一行的
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯嗯，和 json 文件类型有关系

crazyair
crazyair reviewed Oct 23, 2023
View reviewed changes
.gitignore Outdated
@@ -39,4 +39,7 @@ tsconfig.test.json
.storybook
storybook/index.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这应该是历史产物了

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

老代码不去动了

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个可以删，storybook 在 dumi1 迁移的时候就可以去掉了

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

行

@crazyair
Copy link
Contributor

node 16

crazyair
crazyair reviewed Oct 24, 2023
View reviewed changes
package.json Outdated
@@ -32,6 +32,7 @@
"scripts": {
"start": "dumi dev",
"build": "dumi build",
"prepare": "dumi setup --ignore-scripts",
Copy link
Contributor

@crazyair crazyair Oct 24, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--ignore-scripts 这个好像是用 16需要加，而用 18不需要加？我的项目本地 16，执行 setup 也没报错，这里为什么一定要加？

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不是这里加的，应该是 ci 里的 npm i --package-lock-only 后面要加 --ignore-scripts
因为 node 16 的 bug 是 --package-lock-only 也会执行 prepare，而依赖并没有被真实安装，所以会报错找不到 dumi

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

18 可以不用加试试

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

刚才 ci 报错了，还是之前那个问题，所以加了下试试

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #988 (723dafa) into master (c4d78ab) will not change coverage.
The diff coverage is n/a.

❗ Current head 723dafa differs from pull request most recent head 595cfd8. Consider uploading reports for the commit 595cfd8 to get more accurate results

@@           Coverage Diff           @@
##           master     #988   +/-   ##
=======================================
  Coverage   99.78%   99.78%           
=======================================
  Files          38       38           
  Lines        1373     1373           
  Branches      375      400   +25     
=======================================
  Hits         1370     1370           
  Misses          3        3

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MadCcc MadCcc mentioned this pull request Oct 24, 2023
Closed
23 tasks
@MadCcc MadCcc merged commit eda3dca into react-component:master Oct 24, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MadCcc MadCcc MadCcc left review comments

@crazyair crazyair crazyair left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RedJue @crazyair @MadCcc