feat: Implement `optionRender` API #987

RedJue · 2023-10-23T09:09:17Z

vercel · 2023-10-23T09:09:22Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
select	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 25, 2023 3:33am

codecov · 2023-10-23T09:21:30Z

Codecov Report

Merging #987 (7289a86) into master (eda3dca) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 7289a86 differs from pull request most recent head c07e7fd. Consider uploading reports for the commit c07e7fd to get more accurate results

@@           Coverage Diff           @@
##           master     #987   +/-   ##
=======================================
  Coverage   99.78%   99.78%           
=======================================
  Files          38       38           
  Lines        1373     1376    +3     
  Branches      400      403    +3     
=======================================
+ Hits         1370     1373    +3     
  Misses          3        3

Files	Coverage Δ
src/OptionList.tsx	`99.34% <100.00%> (+0.01%)`	⬆️
src/Select.tsx	`100.00% <ø> (ø)`
src/SelectContext.ts	`100.00% <ø> (ø)`

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

vercel · 2023-10-23T10:00:20Z

@RedJue is attempting to deploy a commit to the React Component Team on Vercel.

A member of the Team first needs to authorize it.

zombieJ · 2023-10-24T02:55:17Z

src/OptionList.tsx

-              <div className={`${optionPrefixCls}-content`}>{content}</div>
+              <div className={`${optionPrefixCls}-content`}>
+                {typeof optionRender === 'function'
+                  ? optionRender({


和 SubItem 的 API 对齐吧：

type OptionRender = (oriOption, info: { index }) => ReactNode;

早期，给的东西不用太多。index 就够了~

ref https://github.com/ant-design/ant-design/wiki/API-Naming-rules#props

ok 我改下

crazyair · 2023-10-24T03:49:52Z

README.md

@@ -4,6 +4,7 @@

 React Select

+<!-- prettier-ignore -->


可以直接在 prettier ignore 文件中加上过滤

crazyair · 2023-10-24T03:51:14Z

README.md

@@ -67,6 +68,7 @@ export default () => (

 ### Select props

+<!-- prettier-ignore -->


这个格式化，可以在 prettierrc 里加

overrides: [ { files: '*.md', options: { proseWrap: 'never' } } ]

改是直接加方便点，这样就是全局配了，应该也可以

zombieJ · 2023-10-25T02:15:35Z

src/OptionList.tsx

-              <div className={`${optionPrefixCls}-content`}>{content}</div>
+              <div className={`${optionPrefixCls}-content`}>
+                {typeof optionRender === 'function'
+                  ? optionRender({ ...item.data, label: item.label }, { index: itemIndex })


😼 我给 param 起名叫 oriOption 就是意思不要去改这个 label 的意思哈。option 拿到什么就返回什么。

zombieJ · 2023-10-25T03:14:53Z

src/Select.tsx

@@ -138,6 +140,7 @@ export interface SelectProps<ValueType = any, OptionType extends BaseOptionType
  optionLabelProp?: string;
  children?: React.ReactNode;
  options?: OptionType[];
+  optionRender?: (oriOption: OriOptionType, info: { index: number }) => React.ReactNode;


这么写 option 的泛型没了

RedJue changed the title ~~feat: implement optionRender api~~ feat: Implement optionRender API Oct 23, 2023

vercel bot had a problem deploying to Preview October 23, 2023 09:10 Failure

RedJue force-pushed the feat-option-render branch from 5c30e98 to c8b5a35 Compare October 23, 2023 10:08

RedJue added 2 commits October 24, 2023 10:27

feat: implement optionRender api

dd203b5

chore: clean code

6b9292b

RedJue force-pushed the feat-option-render branch from c8b5a35 to 6b9292b Compare October 24, 2023 02:28

vercel bot deployed to Preview October 24, 2023 02:30 View deployment

docs: update md

d231afa

vercel bot deployed to Preview October 24, 2023 02:33 View deployment

zombieJ reviewed Oct 24, 2023

View reviewed changes

refactor: modify api

ba330ec

vercel bot deployed to Preview October 24, 2023 03:38 View deployment

crazyair reviewed Oct 24, 2023

View reviewed changes

README.md

@@ -4,6 +4,7 @@

React Select



Copy link

Contributor

crazyair Oct 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以直接在 prettier ignore 文件中加上过滤

crazyair reviewed Oct 24, 2023

View reviewed changes

zombieJ reviewed Oct 25, 2023

View reviewed changes

vercel bot deployed to Preview October 25, 2023 02:49 View deployment

zombieJ reviewed Oct 25, 2023

View reviewed changes

refactor: fix type definition

c07e7fd

RedJue force-pushed the feat-option-render branch from 614cc31 to c07e7fd Compare October 25, 2023 03:31

vercel bot deployed to Preview October 25, 2023 03:33 View deployment

zombieJ approved these changes Oct 25, 2023

View reviewed changes

zombieJ merged commit 44d9806 into react-component:master Oct 25, 2023
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Implement `optionRender` API #987

feat: Implement `optionRender` API #987

RedJue commented Oct 23, 2023

vercel bot commented Oct 23, 2023 •

edited

Loading

codecov bot commented Oct 23, 2023 •

edited

Loading

vercel bot commented Oct 23, 2023

zombieJ Oct 24, 2023

RedJue Oct 24, 2023

crazyair Oct 24, 2023

crazyair Oct 24, 2023 •

edited

Loading

RedJue Oct 24, 2023

zombieJ Oct 25, 2023

RedJue Oct 25, 2023

zombieJ Oct 25, 2023

RedJue Oct 25, 2023

swiftwind0405 Jan 9, 2024

		@@ -67,6 +68,7 @@ export default () => (

		### Select props

		<!-- prettier-ignore -->

feat: Implement optionRender API #987

feat: Implement optionRender API #987

Conversation

RedJue commented Oct 23, 2023

vercel bot commented Oct 23, 2023 • edited Loading

codecov bot commented Oct 23, 2023 • edited Loading

Codecov Report

vercel bot commented Oct 23, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

crazyair Oct 24, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

feat: Implement `optionRender` API #987

feat: Implement `optionRender` API #987

vercel bot commented Oct 23, 2023 •

edited

Loading

codecov bot commented Oct 23, 2023 •

edited

Loading

crazyair Oct 24, 2023 •

edited

Loading