fix: trigger onBlur does not require reset focused #980
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
来个测试用例 |
好了~ |
Codecov Report
@@ Coverage Diff @@
## master #980 +/- ##
=======================================
Coverage 99.78% 99.78%
=======================================
Files 38 38
Lines 1370 1373 +3
Branches 400 400
=======================================
+ Hits 1367 1370 +3
Misses 3 3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tests/focus.test.tsx
Outdated
| fireEvent.focus(container.querySelector('input')); | ||
| jest.runAllTimers(); | ||
|
|
||
| expect(container.querySelector('.rc-select-focused')).toBeTruthy(); |
There was a problem hiding this comment.
这个用例感觉不对，上一步 focus input 之后这里必然是 truthy
There was a problem hiding this comment.
最开始的 focus 有触发 onBlur 取消掉，后续重新 focus input 到这里应当是 truthy。这个问题是由于 disabled 重置了 focused 导致无法再次触发 focus，所以这里逻辑应该没问题。
There was a problem hiding this comment.
感觉上应该是判断 onFocus 事件有没有触发？focus 状态是有的，但是原问题是内部的 focus 状态错误地保留了导致没有触发 foucs 事件。
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
close ant-design/ant-design#44619
问题出现原因：在
Select触发onBlur后其disabled为 true 时触发了重置 focused 的操作，将onBlur要执行的回调给清除掉了。