fix: tagRender should not be called when value is empty

[afc163]

Summary by CodeRabbit

• 新功能

  • 无新功能

• Bug 修复

  • 修复了在选择器中没有选中值时的渲染行为
  • 确保当值为空时不会调用标签渲染函数

• 测试

  • 添加了针对空值情况的测试用例，提高了代码的健壮性

这些更改改进了组件的渲染逻辑和测试覆盖率，确保在处理空值时的正确行为。

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
select	❌ Failed (Inspect)			Jan 12, 2025 7:29am

[coderabbitai]

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/Selector/MultipleSelector.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

Error: Cannot read config file: /.eslintrc.js
Error: Cannot find module '@umijs/fabric/dist/eslint'
Require stack:

• /.eslintrc.js
• /node_modules/.pnpm/@eslint[email protected]/node_modules/@eslint/eslintrc/dist/eslintrc.cjs
• /node_modules/.pnpm/[email protected]/node_modules/eslint/lib/cli-engine/cli-engine.js
• /node_modules/.pnpm/[email protected]/node_modules/eslint/lib/eslint/eslint.js
• /node_modules/.pnpm/[email protected]/node_modules/eslint/lib/eslint/index.js
• /node_modules/.pnpm/[email protected]/node_modules/eslint/lib/cli.js
• /node_modules/.pnpm/[email protected]/node_modules/eslint/bin/eslint.js
  at Module._resolveFilename (node:internal/modules/cjs/loader:1248:15)
  at Module._load (node:internal/modules/cjs/loader:1074:27)
  at TracingChannel.traceSync (node:diagnostics_channel:315:14)
  at wrapModuleLoad (node:internal/modules/cjs/loader:217:24)
  at Module.require (node:internal/modules/cjs/loader:1339:12)
  at require (node:internal/modules/helpers:135:16)
  at Object. (/.eslintrc.js:1:14)
  at Module._compile (node:internal/modules/cjs/loader:1546:14)
  at Module._extensions..js (node:internal/modules/cjs/loader:1691:10)
  at Module.load (node:internal/modules/cjs/loader:1317:32)

变更概述

演练

此次拉取请求包含两个主要变更：在 src/Selector/MultipleSelector.tsx 中，为 renderRest 函数添加了一个条件检查，确保当 values 数组为空时返回 null；同时在 tests/Tags.test.tsx 中新增了一个测试用例，验证当 value 为空数组时 tagRender 函数不会被调用。这些变更旨在改进渲染逻辑和测试覆盖率。

变更

文件	变更摘要
src/Selector/MultipleSelector.tsx	在 renderRest 函数中添加条件检查，当 values 为空时返回 null
tests/Tags.test.tsx	新增测试用例，验证空值情况下 tagRender 函数不会被调用

可能相关的 PR

• feat：Give the parameter 'info' field 'index' of the renderItem method in rc-overflow to the tagRender method #1102：与 index 参数处理和 renderItem 方法相关的变更

建议的审阅者

• zombieJ

诗歌

🐰 选择器的魔法，
空值来了不慌张，
渲染逻辑严谨又轻狂，
测试用例护代码方向，
兔子微笑，代码飞扬！

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.25%. Comparing base (fa18f57) to head (22a6831).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1109   +/-   ##
=======================================
  Coverage   98.24%   98.25%           
=======================================
  Files          39       39           
  Lines        1484     1486    +2     
  Branches      420      442   +22     
=======================================
+ Hits         1458     1460    +2     
  Misses         26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/Selector/MultipleSelector.tsx (1)

191-194: 代码逻辑正确，建议小幅优化！

提前返回空值的处理很合理，可以避免不必要的渲染。建议添加更详细的注释说明这个优化的目的。

 // https://github.com/ant-design/ant-design/issues/48930
+// 当没有选中值时提前返回null，避免不必要的渲染
 if (!values.length) {
   return null;
 }

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fa18f57 and 22a6831.

📒 Files selected for processing (2)

• src/Selector/MultipleSelector.tsx (1 hunks)
• tests/Tags.test.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Analyze (javascript)

🔇 Additional comments (1)

tests/Tags.test.tsx (1)

326-338: 测试用例设计合理！

测试用例很好地验证了当value为空数组时不会调用tagRender函数的行为。测试覆盖了修复的核心功能。