fix: Select support maxCount #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1015 +/- ##
=======================================
Coverage 99.78% 99.78%
=======================================
Files 38 38
Lines 1389 1396 +7
Branches 385 390 +5
=======================================
+ Hits 1386 1393 +7
Misses 3 3 ☔ View full report in Codecov by Sentry. |
MadCcc
reviewed
Dec 29, 2023
Co-authored-by: MadCcc <[email protected]>
MadCcc
reviewed
Dec 29, 2023
Co-authored-by: MadCcc <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
20 tasks
MadCcc
reviewed
Jan 2, 2024
Co-authored-by: MadCcc <[email protected]>
MadCcc
reviewed
Jan 2, 2024
Comment on lines
+402
to
+404
| if (rawValues?.size >= maxCount) { | ||
| return; | ||
| } |
MadCcc
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
上个 PR 功能不是很完整，缺少一个分词截断功能，补充一下：
Kapture.2023-12-29.at.02.24.48.mp4