chore: add value type

react-component · Sep 19, 2023 · b92640a · b92640a
1 parent 13a5a28
commit b92640a
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 19 deletions.
diff --git a/src/Input.tsx b/src/Input.tsx
@@ -110,23 +110,28 @@ const Input = forwardRef<InputRef, InputProps>((props, ref) => {
 
   const getInputElement = () => {
     // Fix https://fb.me/react-unknown-prop
-    const otherProps = omit(props as InputProps, [
-      'prefixCls',
-      'onPressEnter',
-      'addonBefore',
-      'addonAfter',
-      'prefix',
-      'suffix',
-      'allowClear',
-      // Input elements must be either controlled or uncontrolled,
-      // specify either the value prop, or the defaultValue prop, but not both.
-      'defaultValue',
-      'showCount',
-      'classes',
-      'htmlSize',
-      'styles',
-      'classNames',
-    ]);
+    const otherProps = omit(
+      props as Omit<InputProps, 'value'> & {
+        value?: React.InputHTMLAttributes<HTMLInputElement>['value'];
+      },
+      [
+        'prefixCls',
+        'onPressEnter',
+        'addonBefore',
+        'addonAfter',
+        'prefix',
+        'suffix',
+        'allowClear',
+        // Input elements must be either controlled or uncontrolled,
+        // specify either the value prop, or the defaultValue prop, but not both.
+        'defaultValue',
+        'showCount',
+        'classes',
+        'htmlSize',
+        'styles',
+        'classNames',
+      ],
+    );
     return (
       <input
         autoComplete={autoComplete}

diff --git a/src/interface.ts b/src/interface.ts
@@ -35,8 +35,10 @@ export interface CommonInputProps {
 
 type DataAttr = Record<`data-${string}`, string>;
 
+export type ValueType = InputHTMLAttributes<HTMLInputElement>['value'] | bigint;
+
 export interface BaseInputProps extends CommonInputProps {
-  value?: InputHTMLAttributes<HTMLInputElement>['value'];
+  value?: ValueType;
   inputElement: ReactElement;
   prefixCls?: string;
   className?: string;
@@ -68,7 +70,11 @@ export interface ShowCountProps {
 
 export interface InputProps
   extends CommonInputProps,
-    Omit<InputHTMLAttributes<HTMLInputElement>, 'size' | 'prefix' | 'type'> {
+    Omit<
+      InputHTMLAttributes<HTMLInputElement>,
+      'size' | 'prefix' | 'type' | 'value'
+    > {
+  value?: ValueType;
   prefixCls?: string;
   // ref: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#%3Cinput%3E_types
   type?: LiteralUnion<

diff --git a/tests/index.test.tsx b/tests/index.test.tsx
@@ -75,6 +75,10 @@ describe('Input', () => {
     await user.click(container.querySelector('.rc-input-clear-icon')!);
     expect(document.activeElement).toBe(container.querySelector('input'));
   });
+
+  it('support bigint type', () => {
+    expect(<Input value={BigInt('2222')} />).toBeTruthy();
+  });
 });
 
 describe('should support showCount', () => {