Dynamic Imports of SDK Modules #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Issue with linting or unit tests detected. |
kschrief
requested changes
Nov 27, 2024
|
No TOKENS are being passed anywhere. I anticipate blackduck scan will be approved once manual review is complete. |
|
b'## WARNING: A Blackduck scan failure has been waived A prior failure has been upvoted
|
|
Issue with linting or unit tests detected. |
1 similar comment
|
Issue with linting or unit tests detected. |
|
Issue with linting or unit tests detected. |
|
Issue with linting or unit tests detected. |
kschrief
approved these changes
Dec 16, 2024
neeradanelxsi
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently we have tagged branches in FCA but those version tags correspond to the Firebolt SDK version and do not have any barring on FCA. There are differences in tagged versions in FCA but they are not required.
This setup causes issues when there is a breaking change that goes into FCA that is also required in every tagged version. These occurrences require a rapid set of PRs to fix all tagged branches and then deploy.
Since the only required difference in the tagged branches is the version of SDK, we can simplify the situation by getting rid of all the tagged branches and just updating the SDK version FCA uses for each build. With each SDK specific FCA build we can deploy to the tagged FCA endpoints.
This PR handles dynamic imports for the FireboltExampleInvoker file as well as the SDK imports in constants.