fix: Addressed architectural review comments #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failed to create a report: |
…to review-comments-1-4-0
|
Core SDK - MFOS standalone sanity report: |
asydnes-cc
approved these changes
Sep 18, 2024
kschrief
pushed a commit
that referenced
this pull request
Sep 18, 2024
# [1.4.0-next.7](v1.4.0-next.6...v1.4.0-next.7) (2024-09-18) ### Bug Fixes * Addressed architectural review comments ([#316](#316)) ([a89275a](a89275a))
|
🎉 This PR is included in version 1.4.0-next.7 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
kschrief
pushed a commit
that referenced
this pull request
Sep 23, 2024
# [1.4.0](v1.3.0...v1.4.0) (2024-09-23) ### Bug Fixes * Added deprecation note in screen resolution method ([#323](#323)) ([e146c43](e146c43)) * Added individual sdk openrpcs to the doc specification ([#311](#311)) ([ace1d64](ace1d64)) * Addressed architectural review comments ([#316](#316)) ([a89275a](a89275a)) * Adjust type in CPP device template due to openrpc change ([#307](#307)) ([1f10a15](1f10a15)) * Bump firebolt-openrpc to fix typescript ([#305](#305)) ([62887cf](62887cf)) * CHANGELOG.md links ([972ab20](972ab20)) * CI fix for file exists ([#308](#308)) ([b44c11a](b44c11a)) * core CHANGELOG.md links ([9987742](9987742)) * Modified device.hdr description ([#319](#319)) ([fd2bfb0](fd2bfb0)) * Reverted App selection tag change ([#322](#322)) ([eee90e4](eee90e4)) * Spec and Doc fixes ([#302](#302)) ([6010a85](6010a85)) * Update to CHANGELOG.md for Release 1.4.0 ([a509cb6](a509cb6)) * Updated the artifact upload version for workflow ([#317](#317)) ([ef9b441](ef9b441)) * Updated xrn:firebolt:capability:secondscreen:protocol to should ([#310](#310)) ([1895fe6](1895fe6)) ### Features * Add global subscribe & HDMI tests to manage test app ([#320](#320)) ([63962ab](63962ab)) * Add OpenRPC to generated C++ SDK ([#314](#314)) ([6ed96cb](6ed96cb)) * Fix Core SDK test app ([#321](#321)) ([3a78534](3a78534)) * Spec and Doc fixes for Release 1.4.0 ([#304](#304)) ([191664b](191664b))
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.