fix: Add enumerated values for fontFamily/fontEdge (#181)

* fix: Add enumerated values for fontFamily/fontEdge * fix: Fixing example to match new enums
rdkcentral · Sep 12, 2023 · de35cb8 · de35cb8
1 parent dd45f8a
commit de35cb8
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 8 deletions.
diff --git a/src/openrpc/accessibility.json b/src/openrpc/accessibility.json
@@ -39,7 +39,7 @@
             "value": {
               "enabled": true,
               "styles": {
-                "fontFamily": "Monospace sans-serif",
+                "fontFamily": "monospaced_sanserif",
                 "fontSize": 1,
                 "fontColor": "#ffffff",
                 "fontEdge": "none",
@@ -92,7 +92,7 @@
             "value": {
               "enabled": true,
               "styles": {
-                "fontFamily": "Monospace sans-serif",
+                "fontFamily": "monospaced_sanserif",
                 "fontSize": 1,
                 "fontColor": "#ffffff",
                 "fontEdge": "none",

diff --git a/src/openrpc/closed_captions.json b/src/openrpc/closed_captions.json
@@ -73,7 +73,7 @@
                     "params": [],
                     "result": {
                         "name": "family",
-                        "value": "monospace"
+                        "value": "monospaced_sanserif"
                     }
                 },
                 {
@@ -225,7 +225,7 @@
                     "params": [],
                     "result": {
                         "name": "edge",
-                        "value": "solid"
+                        "value": "uniform"
                     }
                 },
                 {

diff --git a/src/schemas/accessibility.json b/src/schemas/accessibility.json
@@ -11,14 +11,33 @@
     ],
     "definitions": {
         "FontFamily": {
-            "type": ["string", "null"]
+            "type": ["string", "null"],
+            "enum": [
+                "monospaced_serif",
+                "proportional_serif",
+                "monospaced_sanserif",
+                "proportional_sanserif",
+                "smallcaps",
+                "cursive",
+                "casual",
+                null
+            ]
         },
         "FontSize": {
             "type": ["number", "null"],
             "minimum": 0
         },
         "FontEdge": {
-            "type": ["string", "null"]
+            "type": ["string", "null"],
+            "enum": [
+                "none",
+                "raised",
+                "depressed",
+                "uniform",
+                "drop_shadow_left",
+                "drop_shadow_right",
+                null
+            ]
         },
         "Color": {
             "type": ["string", "null"]
@@ -103,7 +122,7 @@
                 {
                     "enabled": true,
                     "styles": {
-                        "fontFamily": "Monospace sans-serif",
+                        "fontFamily": "monospaced_serif",
                         "fontSize": 1,
                         "fontColor": "#ffffff",
                         "fontEdge": "none",

diff --git a/src/sdks/manage/test/suite/closedCaptions.test.ts b/src/sdks/manage/test/suite/closedCaptions.test.ts
@@ -27,7 +27,7 @@ test("ClosedCaptions.enabled()", () => {
 
 test("ClosedCaptions.fontFamily()", () => {
   return ClosedCaptions.fontFamily().then((res: string) => {
-    expect(res).toEqual("monospace");
+    expect(res).toEqual("monospaced_sanserif");
   });
 });