Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Actions] Adding a MacOS build workflow, fixing several MacOS specific compilation errors and warnings #1788

Merged
merged 92 commits into from
Nov 7, 2024
Merged

[Actions] Adding a MacOS build workflow, fixing several MacOS specific compilation errors and warnings #1788

merged 92 commits into from
Nov 7, 2024

Conversation

VeithMetro
Copy link
Contributor

No description provided.

@VeithMetro
Create MacOS build template
bf779a6
@VeithMetro
Add a condition to trigger this workflow on pushes to the development…
7b87fdb 
… branch
@VeithMetro
Removing the gcc multilib and building 32 bits in macOS for now
050c171
@VeithMetro
Replacing the Linux package instalation steps with its equivalents fo…
620024c 
…r MacOS
@VeithMetro
Updating the commands with pipx instead of pip3
f73f264
@VeithMetro
No need to install pipx as it is already present
1b49634
@VeithMetro
Simplify the packages instalation
4331d0b
@VeithMetro
Install jsonref within a virtual environment instead
bd0ae97
@VeithMetro
Making sure to activate the python virtual environemtn before building
fbc02ab
@VeithMetro
Make sure #pragma clang system_header will be used in portability for…
9e4ad22 
… apple builds
@VeithMetro
See if ignoring -Wgnu-zero-variadic-macro-arguments works
05a454e
@VeithMetro
Looks like for AppleClang the system header doesn't suppress warnings…
cb14e46 
… like in regular clang or gcc
@VeithMetro
Adding VARIABLE_IS_NOT_USED macro for length in MACAddress
066642c
@VeithMetro
Commenting some more unused params
e3ec84f
@VeithMetro
Make sure the condition order is correct
153e73c
@VeithMetro
No need to redefine __APPLE_USE_RFC_3542 macro as it is already defin…
0b93c11 
…ed in the cmake

And having it redefined here caused warnings treated as errors:

/Users/runner/work/Thunder/Thunder/Thunder/Source/core/Portability.h:440:9: error: '__APPLE_USE_RFC_3542' macro redefined [-Werror,-Wmacro-redefined]
#define __APPLE_USE_RFC_3542
        ^
<command line>:7:9: note: previous definition is here
#define __APPLE_USE_RFC_3542 1
        ^
@VeithMetro
Removing unnecessary extern keyword on methods which already have ext…
dabcf4c 
…ern "C"
@VeithMetro
Commenting some unused parameters
5ac354f 
We could also use the macro, but since we are not even using these params in Debug, this seems a bit cleaner
@VeithMetro
Adding a VARIABLE_IS_NOT_USED macro to the AdapterObserver private me…
65ddf81 
…mber
@VeithMetro
Commenting some more unused params in Protability.cpp
7c37fed
@VeithMetro
Add VARIABLE_IS_NOT_USED macro to the Iterator in ProcessInfo
cd4a384 
Here we are using the macro as these params are in fact used on Linux
@VeithMetro
Some more unused params in ProcessInfo.cpp
7e11c57
@VeithMetro
Adding VARIABLE_IS_NOT_USED macro to SystemInfo SetTime method
3773c25
@VeithMetro
m_lastUpdateCpuStats is not used on MacOS
96c346b
@VeithMetro
Params of Thread::GetCallstack() can also be unused
d5c6d32
@VeithMetro
Variable used only in an ASSERT in StreamText
a92de04
@VeithMetro
Marking Id() method from IPCChannelType as an override
55b96f8 
as it is indeed an override of method from IPCChannel
@VeithMetro
Index in CreateFactory is only used in an ASSERT
7d1b870
@VeithMetro
Mark Deinitialize in RunCContainerAdministrator as an override
4781071
@VeithMetro
whole-archive flags are specific to GNU, changing to force_load for A…
51a0761 
…pple instead
@VeithMetro
Update the logic of __SIZEOF_POINTER__ is not defined
3cbe54b
@VeithMetro
Add errors for debugging
e20ff28
@VeithMetro
More debugging
e768792
@VeithMetro
Remove the diagnostic errors
ecb351c
@VeithMetro
Cannot use reinterpret from uint to another uint
5ad62f2
@VeithMetro
Change is_same to is_convertiable to work with other pointers than void*
2ef60d5
@VeithMetro
Use is_pointer instead of is_convertible for even greater portability
af5e0ce
@VeithMetro
More debugging
6ff5b88
@VeithMetro
Formatting changes
280bb36
@VeithMetro
Remove debugging code
15aa950
@VeithMetro
Removing some unnecessary changes
af447f3
@VeithMetro
Bringing back endif removed by accident
0e7e64a
@VeithMetro
Make the template callable
5773a48
@VeithMetro
Make sure to build with this branch in other repos on calls
6f6ffef
@VeithMetro
Add a build workflow
c4a42c5
@VeithMetro
Correct an else instead of an elif
44cf8b5
@VeithMetro
Add debugging
4e42239
@VeithMetro
Formatting changes, removing the debugging code
7c28dd2
@VeithMetro
Change the runner version to be static
fb5b7d4
@VeithMetro
Prep for merging to master
b375c29
@VeithMetro VeithMetro requested a review from sebaszm November 5, 2024 08:52
pwielders
pwielders reviewed Nov 5, 2024
View reviewed changes
Source/core/Factory.h Outdated Show resolved Hide resolved
pwielders
pwielders reviewed Nov 5, 2024
View reviewed changes
Copy link
Contributor

@pwielders pwielders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, small remark, but now we have a warning free build on Apple as well ?

@VeithMetro
Copy link
Contributor Author

VeithMetro commented Nov 6, 2024 •
edited
Loading

Well done, small remark, but now we have a warning free build on Apple as well ?

@pwielders indeed we have! At least for Thunder, but other repos will follow shortly 😄

@VeithMetro VeithMetro requested a review from pwielders November 6, 2024 07:40
@pwielders pwielders merged commit 1ecc540 into master Nov 7, 2024
57 checks passed
@pwielders pwielders deleted the development/actions-macos-release branch November 7, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebaszm sebaszm sebaszm approved these changes

@pwielders pwielders Awaiting requested review from pwielders

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VeithMetro @pwielders @sebaszm