[METADATA] Expose all COMRPC metadata like Channels and Proxies (also… #1775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the private channels)
MFransen69
previously approved these changes
Oct 14, 2024
Source/com/IUnknown.cpp
Outdated
| if (comchannel != nullptr) { | ||
| result = &(comchannel->Source()); | ||
| return (comchannel->Extension().Origin()); |
There was a problem hiding this comment.
Coverity issue no longer present as of: undefined
Show issue
Coverity Issue - Missing unlock
Returning without unlocking "this->_adminLock.m_syncMutex".
Medium Impact, CWE-667
LOCK
Thank you Coverity! I like tools that add value :-)
|
Also see: |
MFransen69
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… the private channels)