Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core/cyclicbuffer] : Cherry-picked 'd174173def790fcd8ef1d67f28a121db……bbd44f1c' and 'a91e6a70d2afa6ccb6bf793c194ecb72a57530f9' from 'development/cyclicbuffer'. #1534

Closed
wants to merge 7 commits into from

Conversation

msieben
Copy link
Contributor

@msieben msieben commented Feb 27, 2024

As discussed with @MFransen69.

Intended to resolve (spurious) deadlocks.

…bbd44f1c' and 'a91e6a70d2afa6ccb6bf793c194ecb72a57530f9' from 'development/cyclicbuffer'.

- 'pthread_cond_wait' and 'pthread_cond_timedwait' should be guarded per POSIX specification.

- 'std::this_thread_yield' loop deadlocks on 'agents'.

- atomics do not require barriers. Do not lock longer than required as locks cost cycles.

- Only one can have taken the 'Signallock'. Only one should be signalled to be released.
@msieben msieben requested a review from VeithMetro May 24, 2024 10:42
@msieben
Copy link
Contributor Author

msieben commented Jun 26, 2024

Closing PR. Low priority. More information at https://jira.rdkcentral.com/jira/browse/METROL-1001.

@msieben msieben closed this Jun 26, 2024
@pwielders pwielders deleted the development/cyclicbuffer-deadlock-on-agents branch October 11, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant