[WINDOWS] Make sure warning reporting is not enabled from the core pr… #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oject file. As warning reporting is optional, I think it is good to enable WarningReporitng builds from the outside. If so the build (by default) does not get to bulky (lean and mean) and if you want WarningReproting just pass the flag from the ourside (if possible :-). Also the MessageDispatcher.h is nolonger part of this deplyment, lets kill it :-)
VeithMetro
approved these changes
Oct 4, 2023
bramoosterhuis
pushed a commit
to bramoosterhuis/Thunder
that referenced
this pull request
Apr 26, 2024
…oject file. (rdkcentral#1419) As warning reporting is optional, I think it is good to enable WarningReporting builds from the outside. If so the build (by default) does not get to bulky (lean and mean) and if you want WarningReporting just pass the flag from the outside (if possible :-). Also the MessageDispatcher.h is no longer part of this deployment, lets kill it :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…oject file.
As warning reporting is optional, I think it is good to enable WarningReporitng builds from the outside. If so the build (by default) does not get to bulky (lean and mean) and if you want WarningReproting just pass the flag from the ourside (if possible :-).
Also the MessageDispatcher.h is nolonger part of this deplyment, lets kill it :-)