[Actions] [Warning Reporting] Adding Warning Reporting to be built in Actions for Windows #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwielders
previously approved these changes
Oct 4, 2023
|
After we disabled warning reporting from being build in core by default on Windows, this feature is on hold for now, since we need to figure out the best way to enabled warning reporting in core on Windows builds only when we want to build warning reporting extension |
VeithMetro
force-pushed
the
development/windows-system-headers
branch
from
f862630 to
1b16edc
Compare
… adding warning reporting
…nv since it restores packages
…om/VeithMetro/Thunder into development/windows-system-headers
…ings in the future
…om/VeithMetro/Thunder into development/windows-system-headers
…om/VeithMetro/Thunder into development/windows-system-headers
pwielders
approved these changes
Dec 4, 2023
bramoosterhuis
pushed a commit
to bramoosterhuis/Thunder
that referenced
this pull request
Apr 26, 2024
… Actions for Windows (rdkcentral#1416) * Adding warning reporting project to be built in actions on Windows * Adding WarningReportingCategories.cpp to the core project file * Adding an empty define of ANNOUNCE_WARNING for warning free builds * Adding preprocessor define in the command line * Update Build Thunder on Windows.yml * Trying a different project name * Adding a folder of core * Changing the syntax to match Windows * Adding bridge project to be build as well to see if it builds dependences first * Adding $(DefineConstants) to make sure we are not clearing them while adding warning reporting * Trying to build just bridge * Trying to build the whole solution with msbuild * Trying a different approach with setting env variables and using devenv since it restores packages * Building once again with devenv but setting env variable beforehand * Changing the name to be more generic since it can be used for more things in the future * Preparing for a pull request, cleaning everything up * Removing variables which are no longer needed * Adding props to enable setting the env variable in Visual Studio * Making sure by default the macro value is empty to override the other one * Adding a separate variable for console builds * Using the new console variable since it was clashing with the Visual Studio one --------- Co-authored-by: Pierre Wielders <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.